[Insight-developers] Gerrit Reviewed, now what?

Bill Lorensen bill.lorensen at gmail.com
Mon Sep 27 11:45:41 EDT 2010


OK, I though I needed to follow these steps:
http://vtk.org/Wiki/ITK/Git#Topic_Stage

But, Hans and Brad, are you saying this will be done automatically
once the review gets a Verified and a +2?

This could explain what happened to me yesterday. Last night I
followed the instructions at:
http://vtk.org/Wiki/ITK/Git#Topic_Stage

In the git summary here:
http://itk.org/gitweb?p=ITK.git

I see a
27 hours ago
	Bill Lorensen	COMP: Removed warnings caused by unused static procs
and
12 hours ago
	Bill Lorensen	Merge topic 'OpenJpegWarnings'

I think the last one was the one I did and the first one was the robot?

Bill
On Mon, Sep 27, 2010 at 11:36 AM, Brad King <brad.king at kitware.com> wrote:
> On 09/26/2010 06:55 PM, Hans Johnson wrote:
>> After about 20 minutes you will get an e-mail claiming to be from Brad King,
>> and that e-mail will have information from both gerrit and git stating that
>> the the merge was successfully moved into the itk/master and describe the
>> gerrit review process that occurred.
>
> FYI, this email will now appear to be from "Kitware Robot".
> Gerrit uses the name of the user that pushed the changes
> into its repository.  We have a robot that pushes every
> 10 minutes from itk.org to review.source.kitware.com.
> Previously the robot was using my account in Gerrit but now
> I made an account for the robot for just this purpose.
>
> -Brad
>


More information about the Insight-developers mailing list