<font><font face="verdana,sans-serif">Is ITK still assuming no units, or millimeters are units for pixel spacing?</font></font><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Dec 10, 2012 at 5:25 PM, Bill Lorensen <span dir="ltr"><<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">If you submit a gerrit patch, I'll write or modify a test.<br>
<br>
How will we know if the fix works unless we test it? How will we know<br>
if someone reintroduces the bug if we don't test it?<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
On Mon, Dec 10, 2012 at 10:41 AM, Dženan Zukić <<a href="mailto:dzenanz@gmail.com">dzenanz@gmail.com</a>> wrote:<br>
> But this would be a bug fix, not a patch introducing new features. This<br>
> should already be working, and ideally having a test.<br>
><br>
> I know that many bugs don't get fixed, because they are not important enough<br>
> and there is not enough people working on ITK. However a requirement to<br>
> write a 20-30 line test for a few lines of fixed code is a great deterrence<br>
> for me to contribute bug fixes (such as this one).<br>
><br>
><br>
> On Mon, Dec 10, 2012 at 4:26 PM, Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>><br>
> wrote:<br>
>><br>
>> Looks like ti should be fixed. But if you submit a gerrit patch, make<br>
>> sure oyu also supply a test or modify an existing test.<br>
>><br>
>> The lack of a test is why your previous gerrit patch has not been<br>
>> approved.<br>
>><br>
>> Bill<br>
>><br>
>> On Mon, Dec 10, 2012 at 8:35 AM, Dženan Zukić <<a href="mailto:dzenanz@gmail.com">dzenanz@gmail.com</a>> wrote:<br>
>> > Hi everyone,<br>
>> ><br>
>> > I have noticed that ImageFileWriter, when writing png format, writes<br>
>> > wrong<br>
>> > pixel size information. It is not completely wrong, but it is not in<br>
>> > accordance with png specification.<br>
>> ><br>
>> > When reading such files with OpenCV, I get following warning:<br>
>> > libpng warning: Invalid sCAL ignored: invalid unit<br>
>> > This is not just annoying and clutter-causing, but displaying it for<br>
>> > every<br>
>> > single image slows down my OpenCV processing.<br>
>> ><br>
>> > I used XnView to batch-edit the extracted slices and set some scaling<br>
>> > which<br>
>> > adheres to the specification to get rid of this warning.<br>
>> ><br>
>> > Now the question: should I correct this bug, or submit a bug report? My<br>
>> > last<br>
>> > bug-fixing ended non-gloriously :(<br>
>> ><br>
>> > _____________________________________<br>
>> > Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>> ><br>
>> > Visit other Kitware open-source projects at<br>
>> > <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>> ><br>
>> > Kitware offers ITK Training Courses, for more information visit:<br>
>> > <a href="http://www.kitware.com/products/protraining.php" target="_blank">http://www.kitware.com/products/protraining.php</a><br>
>> ><br>
>> > Please keep messages on-topic and check the ITK FAQ at:<br>
>> > <a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
>> ><br>
>> > Follow this link to subscribe/unsubscribe:<br>
>> > <a href="http://www.itk.org/mailman/listinfo/insight-users" target="_blank">http://www.itk.org/mailman/listinfo/insight-users</a><br>
>> ><br>
>><br>
>><br>
>><br>
>> --<br>
>> Unpaid intern in BillsBasement at noware dot com<br>
><br>
><br>
<br>
<br>
<br>
--<br>
Unpaid intern in BillsBasement at noware dot com<br>
</div></div></blockquote></div><br></div>