<font><font face="verdana,sans-serif">But this would be a bug fix, not a patch introducing new features. This should already be working, and ideally having a test.</font></font><div><font><font face="verdana,sans-serif"><br>
</font></font></div><div><font><font face="verdana,sans-serif">I know that many bugs don't get fixed, because they are not important enough and there is not enough people working on ITK. However a requirement to write a 20-30 line test for a few lines of fixed code is a great deterrence for me to contribute bug fixes (such as this one).</font></font></div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Dec 10, 2012 at 4:26 PM, Bill Lorensen <span dir="ltr"><<a href="mailto:bill.lorensen@gmail.com" target="_blank">bill.lorensen@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Looks like ti should be fixed. But if you submit a gerrit patch, make<br>
sure oyu also supply a test or modify an existing test.<br>
<br>
The lack of a test is why your previous gerrit patch has not been approved.<br>
<br>
Bill<br>
<div><div class="h5"><br>
On Mon, Dec 10, 2012 at 8:35 AM, Dženan Zukić <<a href="mailto:dzenanz@gmail.com">dzenanz@gmail.com</a>> wrote:<br>
> Hi everyone,<br>
><br>
> I have noticed that ImageFileWriter, when writing png format, writes wrong<br>
> pixel size information. It is not completely wrong, but it is not in<br>
> accordance with png specification.<br>
><br>
> When reading such files with OpenCV, I get following warning:<br>
> libpng warning: Invalid sCAL ignored: invalid unit<br>
> This is not just annoying and clutter-causing, but displaying it for every<br>
> single image slows down my OpenCV processing.<br>
><br>
> I used XnView to batch-edit the extracted slices and set some scaling which<br>
> adheres to the specification to get rid of this warning.<br>
><br>
> Now the question: should I correct this bug, or submit a bug report? My last<br>
> bug-fixing ended non-gloriously :(<br>
><br>
</div></div>> _____________________________________<br>
> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
><br>
> Visit other Kitware open-source projects at<br>
> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
><br>
> Kitware offers ITK Training Courses, for more information visit:<br>
> <a href="http://www.kitware.com/products/protraining.php" target="_blank">http://www.kitware.com/products/protraining.php</a><br>
><br>
> Please keep messages on-topic and check the ITK FAQ at:<br>
> <a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
><br>
> Follow this link to subscribe/unsubscribe:<br>
> <a href="http://www.itk.org/mailman/listinfo/insight-users" target="_blank">http://www.itk.org/mailman/listinfo/insight-users</a><br>
><br>
<span class="HOEnZb"><font color="#888888"><br>
<br>
<br>
--<br>
Unpaid intern in BillsBasement at noware dot com<br>
</font></span></blockquote></div><br></div>