Hi Greg,<br><br>Thanks for pointing this out.<br><br>This is a mistake on our part.<br><br>I practice, none of the classes in Code/Review/Statistics<br>should have to use or refer to the symbol:<br><br> ITK_USE_REVIEW_STATISTICS<br>
<br>The reason is that, if the symbol is not defined, then<br>these files should not be included at all in the first place.<br><br>In other words, the only way to get to include these files<br>is to set ITK_USE_REVIEW_STATISTICS to ON.<br>
<br><br>We will remove the ITK_USE_REVIEW_STATISTICS<br>conditionals from that file.<br><br><br> Regards,<br><br><br> Luis<br><br><br>----------------------<br><div class="gmail_quote">On Fri, Aug 7, 2009 at 5:20 PM, Greg Harris <span dir="ltr"><<a href="mailto:Gregory-Harris@uiowa.edu">Gregory-Harris@uiowa.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Oops, I think I misdiagnosed it: in Code/Review/Statistics, the files<br>
itkScalarImageToHistogramGenerator.{h,txx} do not agree when<br>
ITK_USE_REVIEW_STATISTICS is ON: I would add the<br>
#ifndef ITK_USE_REVIEW_STATISTICS<br>
Around the .h prototypes to match the .txx implementations.<br>
<br>
My bad.<br>
<div><div></div><div class="h5"><br>
<br>
On 8/7/09 3:17 PM, "Greg Harris" <<a href="mailto:Gregory-Harris@uiowa.edu">Gregory-Harris@uiowa.edu</a>> wrote:<br>
<br>
> Dear Insight user's help list:<br>
><br>
> I have been compiling ITK with the ITK_USE_REVIEW_STATISTICS flag ON, and<br>
> with wrapping of Tcl turned ON as well. Along the way, there is this<br>
> glitch:<br>
><br>
> While linking a library to include the glue for the wrapping file<br>
> WrapITK/Modules/Calculators/wrap_itkScalarImageToHistogramGenerator.cmake<br>
> the method functions for SetHistogramMax and SetHistogramMin have no<br>
> implementation. Rightly so, but there should be no wrapped methods for<br>
> them.<br>
><br>
> On the face of it, the two versions of ScalarImageToHistogramGenerator,<br>
> Code/Numerics/Statistics/itkScalarImageToHistogramGenerator.{h,txx} and<br>
> Code/Review/Statistics/itkScalarImageToHistogramGenerator.{h,txx} are both<br>
> available to the wrapping compiler, but only the standard version has Set<br>
> methods for HistogramMin and HistogramMax.<br>
><br>
> Since I don't know why -- apparently only in this one case of superceding an<br>
> itk class definition with a Review method, which happens all the time -- the<br>
> Tcl glue-interface is being generated for the standard class by that name<br>
> and then linked against the review definition of the same class name, I have<br>
> temporarily adopted the expedient of renaming<br>
> wrap_itkScalarImageToHistogramGenerator.cmake to a safe place nearby so the<br>
> entire class's glue code won't be generated at all.<br>
><br>
> This won't do for the long run as we would like to wrap the Review version<br>
> of ScalarImageToHistogramGenerator, and we would not like to tamper with the<br>
> source download each time. I know I could devise a patch that modifies the<br>
> Code/Numerics/Statistics copy, but why are we dealing with it at all, after<br>
> ITK_USE_REVIEW_STATISTICS is ON?<br>
><br>
> Should I have a sinking fear that Whenever people supercede a class<br>
> implementation with a Review version, the non-Review version is driving the<br>
> Tcl wrapper glue generation? That would be wrong; it would need serious<br>
> fixing, even if this is the first known case where it has made a difference.<br>
><br>
> I hope someone who knows what's what will kindly help us with this.<br>
> Greg Harris<br>
> Brain Imaging Application Developer<br>
> Iowa Psychiatric Neuroimaging Consortium<br>
> Carver College of Medicine<br>
> The University of Iowa<br>
><br>
> _____________________________________<br>
> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
><br>
> Visit other Kitware open-source projects at<br>
> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
><br>
> Please keep messages on-topic and check the ITK FAQ at:<br>
> <a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
><br>
> Follow this link to subscribe/unsubscribe:<br>
> <a href="http://www.itk.org/mailman/listinfo/insight-users" target="_blank">http://www.itk.org/mailman/listinfo/insight-users</a><br>
<br>
_____________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at<br>
<a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the ITK FAQ at: <a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.itk.org/mailman/listinfo/insight-users" target="_blank">http://www.itk.org/mailman/listinfo/insight-users</a><br>
</div></div></blockquote></div><br>