<br>Sean,<br><br>Yes, <br>this is indeed that same problem of truncating 32 bits to 64 bits.<br><br>I don't see another option different from biting the bullet and <br>fixing the many occurrences in the code... It is not fun, but large<br>
images are one of the few certain things in our future, and <br>pretty much all computers sold today are 64 bits.<br><br><br>A tempting option is to follow the approach we used for fixing<br>the Coding Style: <br><br> Working directory by directory. <br>
<br><br>E.g. fix first all the issues in Code/Common by compiling and<br>running only Code/Common and Testing/Code/Common.<br><br>Then follow with BasicFilter,<br>Then Numerics<br>Then Algorithms<br>... and so on....<br><br>
<br><br> Luis<br><br><br>------------------------------------------------------------------------------------<br><div class="gmail_quote">On Mon, Jul 13, 2009 at 1:01 PM, Sean McBride <span dir="ltr"><<a href="mailto:sean@rogue-research.com">sean@rogue-research.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="im">On 7/13/09 12:04 PM, Michael Jackson said:<br>
<br>
>> This looks like an absolutely massive effort you are attempting<br>
>> here. I have grepped through the iterator classes are there alot of<br>
>> incorrect usages of long:<br>
>><br>
>> itkImageRegionReverseConstIterator.h: m_SpanEndOffset = this-<br>
>> >m_BeginOffset - static_cast<long>(this->m_Region.GetSize()[0]);<br>
><br>
>So that is a "bug" and should be corrected. This effort will help get<br>
>rid of those.. I hope. Turning on -Wall may help track those down a<br>
>bit easier but with the size of the code base of ITK there is going to<br>
>be a large effort to track those down.<br>
<br>
</div>-Wall won't help, it's enabled on many nightlies and gives green dashboards.<br>
<br>
This reminds me of when I tried to turn on gcc's -Wshorten-64-to-32<br>
(only in Apple's fork of gcc IIRC). There were zillions of warnings,<br>
most legit, but most requiring many many changes, including to public<br>
APIs. There are many explicit casts as well as many implicit casts that<br>
need fixing. It would be a massive effort.<br>
<font color="#888888"><br>
--<br>
____________________________________________________________<br>
Sean McBride, B. Eng <a href="mailto:sean@rogue-research.com">sean@rogue-research.com</a><br>
Rogue Research <a href="http://www.rogue-research.com" target="_blank">www.rogue-research.com</a><br>
Mac Software Developer Montréal, Québec, Canada<br>
</font><div><div></div><div class="h5"><br>
<br>
_____________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at<br>
<a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the ITK FAQ at: <a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.itk.org/mailman/listinfo/insight-users" target="_blank">http://www.itk.org/mailman/listinfo/insight-users</a><br>
</div></div></blockquote></div><br>