Hi Bill, <br><br>so far we are only modifying existing tests that were failing. The following tests include new code, <br><br>Code/BasicFilters/itkExpandImageFilterTest.cxx:<br>Code/BasicFilters/itkVectorExpandImageFilterTest.cxx:<br>
Code/Common/itkBSplineDeformableTransformTest2.cxx<br><br>which assume pixel-centeredness. Moreover, many other tests have new regression data committed, and ctest selects the appropriate data set depending on the value of these flags. <br>
<br>Best wishes, <br><br>Michel<br><br><div class="gmail_quote">On Wed, May 20, 2009 at 1:48 PM, Bill Lorensen <span dir="ltr"><<a href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Do we have a test that validates the centered pixel and portable round<br>
options? For example, a 1D example that can be manual verified.<br>
<br>
Bill<br>
<div><div></div><div class="h5"><br>
<br>
On Wed, May 20, 2009 at 1:12 PM, Michel Audette<br>
<<a href="mailto:michel.audette@kitware.com">michel.audette@kitware.com</a>> wrote:<br>
> Dear members of the Insight Community,<br>
><br>
> in response to bug 6558, Luis and I have implemented some changes that<br>
> produce pixel-centered coordinates, as well as a few other needed<br>
> refinements, which are enabled by the flags<br>
> ITK_USE_CENTERED_PIXEL_COORDINATES_CONSISTENTLY,<br>
> ITK_USE_REGION_VALIDATION_IN_ITERATORS and<br>
> ITK_USE_PORTABLE_ROUND<br>
><br>
> With the flags turned off, the code behaves as before, with no failing<br>
> tests. With the flags turned on there are still a number of failing tests,<br>
> that are related to these new coordinates, and which have been whittled down<br>
> from more than 25 to 14 currently.<br>
><br>
> Nonetheless, we would like to get rid of as many of these as we can by next<br>
> Monday, for the upcoming release of ITK, and consequently, we would<br>
> respectfully ask interested members of the community to lend a hand with the<br>
> remaining tests.<br>
><br>
> I will be submitting an Experimental ctest on a regular basis, with the<br>
> signature metropolis-pixelcentered.kitware<br>
> Currently the failing tests are the following.<br>
> 169 - itkSampleSelectiveMeanShiftBlurringFilterTest (Failed)<br>
> 340 - itkMedialNodeCorrespondencesTest (Failed)<br>
> 543 - itkImportImageTest (Failed)<br>
> 572 - itkNonThreadedShrinkImageTest (Failed)<br>
> 594 - itkShrinkImageTest (Failed)<br>
> 615 - itkStreamingImageFilterTest2 (Failed)<br>
> 630 - itkWarpImageFilterTest (Failed)<br>
> 632 - itkWarpVectorImageFilterTest (Failed)<br>
> 800 - itkMattesMutualInformationImageToImageMetricTest (Failed)<br>
> 801 - itkMattesMutualInformationImageToImageMetricTest2 (Failed)<br>
> 802 - itkMattesMutualInformationImageToImageMetricTest3 (Failed)<br>
> 803 - itkMattesMutualInformationImageToImageMetricTest4 (Failed)<br>
> 816 - itkMultiResolutionPDEDeformableRegistrationTest (Failed)<br>
> 1470 - ResampleImageFilter9Test (Failed)<br>
><br>
> I plan to work on failing tests relating to the itkShrinkImageFilter class.<br>
><br>
> Thank you for your kind consideration.<br>
><br>
> Best wishes,<br>
><br>
> Michel<br>
> --<br>
> Michel Audette, Ph.D.<br>
> R & D Engineer,<br>
> Kitware Inc.,<br>
> Chapel Hill, N.C.<br>
><br>
><br>
</div></div>> _______________________________________________<br>
> Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
><br>
> Visit other Kitware open-source projects at<br>
> <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
><br>
> Please keep messages on-topic and check the ITK FAQ at:<br>
> <a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
><br>
> Follow this link to subscribe/unsubscribe:<br>
> <a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
><br>
><br>
</blockquote></div><br><br clear="all"><br>-- <br>Michel Audette, Ph.D. <br>R & D Engineer, <br>Kitware Inc.,<br>Chapel Hill, N.C. <br><br>