Bill,<div><br></div><div>I think the idea is to disable the cell-centered functionality until after the release. I.e. the code will be in, but not enabled in the CMake options. Is this an acceptable alternative?</div><div>
<br></div><div>- Wes</div><div><br><div class="gmail_quote">On Wed, May 20, 2009 at 7:20 PM, Bill Lorensen <span dir="ltr"><<a href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
I understand the current situation. I do believe however that we<br>
should validate the new techniques. Regression testing is meant to<br>
track changes in the code but they do not validate the code. Before we<br>
release ITK with these new capabilities I think we should make sure<br>
the code is correct. Even if this means we have to delay the release.<br>
<br>
Bill<br>
<br>
On Wed, May 20, 2009 at 1:57 PM, Michel Audette<br>
<div><div></div><div class="h5"><<a href="mailto:michel.audette@kitware.com">michel.audette@kitware.com</a>> wrote:<br>
> Hi Bill,<br>
><br>
> so far we are only modifying existing tests that were failing. The following<br>
> tests include new code,<br>
><br>
> Code/BasicFilters/itkExpandImageFilterTest.cxx:<br>
> Code/BasicFilters/itkVectorExpandImageFilterTest.cxx:<br>
> Code/Common/itkBSplineDeformableTransformTest2.cxx<br>
><br>
> which assume pixel-centeredness. Moreover, many other tests have new<br>
> regression data committed, and ctest selects the appropriate data set<br>
> depending on the value of these flags.<br>
><br>
> Best wishes,<br>
><br>
> Michel<br>
><br>
> On Wed, May 20, 2009 at 1:48 PM, Bill Lorensen <<a href="mailto:bill.lorensen@gmail.com">bill.lorensen@gmail.com</a>><br>
> wrote:<br>
>><br>
>> Do we have a test that validates the centered pixel and portable round<br>
>> options? For example, a 1D example that can be manual verified.<br>
>><br>
>> Bill<br>
>><br>
>><br>
>> On Wed, May 20, 2009 at 1:12 PM, Michel Audette<br>
>> <<a href="mailto:michel.audette@kitware.com">michel.audette@kitware.com</a>> wrote:<br>
>> > Dear members of the Insight Community,<br>
>> ><br>
>> > in response to bug 6558, Luis and I have implemented some changes that<br>
>> > produce pixel-centered coordinates, as well as a few other needed<br>
>> > refinements, which are enabled by the flags<br>
>> > ITK_USE_CENTERED_PIXEL_COORDINATES_CONSISTENTLY,<br>
>> > ITK_USE_REGION_VALIDATION_IN_ITERATORS and<br>
>> > ITK_USE_PORTABLE_ROUND<br>
>> ><br>
>> > With the flags turned off, the code behaves as before, with no failing<br>
>> > tests. With the flags turned on there are still a number of failing<br>
>> > tests,<br>
>> > that are related to these new coordinates, and which have been whittled<br>
>> > down<br>
>> > from more than 25 to 14 currently.<br>
>> ><br>
>> > Nonetheless, we would like to get rid of as many of these as we can by<br>
>> > next<br>
>> > Monday, for the upcoming release of ITK, and consequently, we would<br>
>> > respectfully ask interested members of the community to lend a hand with<br>
>> > the<br>
>> > remaining tests.<br>
>> ><br>
>> > I will be submitting an Experimental ctest on a regular basis, with the<br>
>> > signature metropolis-pixelcentered.kitware<br>
>> > Currently the failing tests are the following.<br>
>> > 169 - itkSampleSelectiveMeanShiftBlurringFilterTest (Failed)<br>
>> > 340 - itkMedialNodeCorrespondencesTest (Failed)<br>
>> > 543 - itkImportImageTest (Failed)<br>
>> > 572 - itkNonThreadedShrinkImageTest (Failed)<br>
>> > 594 - itkShrinkImageTest (Failed)<br>
>> > 615 - itkStreamingImageFilterTest2 (Failed)<br>
>> > 630 - itkWarpImageFilterTest (Failed)<br>
>> > 632 - itkWarpVectorImageFilterTest (Failed)<br>
>> > 800 - itkMattesMutualInformationImageToImageMetricTest (Failed)<br>
>> > 801 - itkMattesMutualInformationImageToImageMetricTest2 (Failed)<br>
>> > 802 - itkMattesMutualInformationImageToImageMetricTest3 (Failed)<br>
>> > 803 - itkMattesMutualInformationImageToImageMetricTest4 (Failed)<br>
>> > 816 - itkMultiResolutionPDEDeformableRegistrationTest (Failed)<br>
>> > 1470 - ResampleImageFilter9Test (Failed)<br>
>> ><br>
>> > I plan to work on failing tests relating to the itkShrinkImageFilter<br>
>> > class.<br>
>> ><br>
>> > Thank you for your kind consideration.<br>
>> ><br>
>> > Best wishes,<br>
>> ><br>
>> > Michel<br>
>> > --<br>
>> > Michel Audette, Ph.D.<br>
>> > R & D Engineer,<br>
>> > Kitware Inc.,<br>
>> > Chapel Hill, N.C.<br>
>> ><br>
>> ><br>
>> > _______________________________________________<br>
>> > Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
>> ><br>
>> > Visit other Kitware open-source projects at<br>
>> > <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
>> ><br>
>> > Please keep messages on-topic and check the ITK FAQ at:<br>
>> > <a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
>> ><br>
>> > Follow this link to subscribe/unsubscribe:<br>
>> > <a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
>> ><br>
>> ><br>
><br>
><br>
><br>
> --<br>
> Michel Audette, Ph.D.<br>
> R & D Engineer,<br>
> Kitware Inc.,<br>
> Chapel Hill, N.C.<br>
><br>
><br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Please keep messages on-topic and check the ITK FAQ at: <a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Wesley D. Turner, Ph.D.<br>Kitware, Inc.<br>R&D Engineer<br>28 Corporate Drive<br>Clifton Park, NY 12065-8662<br>Phone: 518-371-3971 x120<br>
</div>