<div dir="ltr">Is there an independent gerrit topic that illustrates this problem?<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jul 9, 2013 at 3:09 PM, Johnson, Hans J <span dir="ltr"><<a href="mailto:hans-johnson@uiowa.edu" target="_blank">hans-johnson@uiowa.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="font-size:14px;font-family:Calibri,sans-serif;word-wrap:break-word">
<div>Adding Matt McCormic to this e-mail. and posting on Insight-developers list to recruit more help.</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<span>
<div style="border-right:medium none;padding-right:0in;padding-left:0in;padding-top:3pt;text-align:left;font-size:11pt;border-bottom:medium none;font-family:Calibri;border-top:#b5c4df 1pt solid;padding-bottom:0in;border-left:medium none">
<span style="font-weight:bold">From: </span>Michael Bowers <<a href="mailto:michaelbowersjhu@gmail.com" target="_blank">michaelbowersjhu@gmail.com</a>><br>
<span style="font-weight:bold">Date: </span>Tuesday, July 9, 2013 2:04 PM<br>
<span style="font-weight:bold">To: </span>Hans Johnson <<a href="mailto:hans-johnson@uiowa.edu" target="_blank">hans-johnson@uiowa.edu</a>><br>
<span style="font-weight:bold">Subject: </span>Re: Change in ITK[master]: ENH: Adaptor for vnl Sparse Symmetric Matrix<br>
</div>
<div><br>
</div>
<div>
<div>
<div dir="ltr"><br>
<div>Hans,</div>
<div><br>
</div>
<div>I'm really sorry it seems like nothing has been happening on this. I've been busy and have also run into a number of roadblocks on what I think we both expected would be a pretty simple test to write.</div>
<div><br>
</div>
<div>Of course my first instinct was to call the vnl_algo code, then the ITK wrapper code and compare the results. They differed. If fact the vnl_sparse_symmetric_eigensystem::CalculateNPairs code returns different results every time I call it for the general
case A * x = lambda * B * x.</div>
<div><br>
</div>
<div>So I added this routine to vxl. I naively assumed the way they did the special case A * x = lambda * x would be okay to use, but that works the same way. They have a static variable that stores the first instantiated variable of this class, and apparently
the saved state affects all subsequent calls to CalculateNPairs.</div>
<div><br>
</div>
<div>So I'm in a bit of a situation where I don't know what to do. Would love any suggestions you might have, and of course I'll continue to work the problem.</div>
<div><br>
</div>
<div>Michael Bowers</div>
<div>Center for Imaging Science</div>
<div>Johns Hopkins University</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Tue, Apr 23, 2013 at 11:23 AM, Johnson, Hans J <span dir="ltr">
<<a href="mailto:hans-johnson@uiowa.edu" target="_blank">hans-johnson@uiowa.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="font-size:14px;font-family:Calibri,sans-serif;word-wrap:break-word">
<div>Thanks! I'm very excited to have this as part of the ITK toolkit. </div>
<div><br>
</div>
<div>Hans</div>
<div><br>
</div>
<div><br>
</div>
<span>
<div style="border-right:medium none;padding-right:0in;padding-left:0in;padding-top:3pt;text-align:left;font-size:11pt;border-bottom:medium none;font-family:Calibri;border-top:#b5c4df 1pt solid;padding-bottom:0in;border-left:medium none">
<span style="font-weight:bold">From: </span>Michael Bowers <<a href="mailto:michaelbowersjhu@gmail.com" target="_blank">michaelbowersjhu@gmail.com</a>><br>
<span style="font-weight:bold">Date: </span>Tuesday, April 23, 2013 10:22 AM<br>
<span style="font-weight:bold">To: </span>Hans Johnson <<a href="mailto:hans-johnson@uiowa.edu" target="_blank">hans-johnson@uiowa.edu</a>>
<div>
<div><br>
<span style="font-weight:bold">Subject: </span>Re: Change in ITK[master]: ENH: Adaptor for vnl Sparse Symmetric Matrix<br>
</div>
</div>
</div>
<div>
<div>
<div><br>
</div>
<div>
<div>
<div> </div>
<div>Very good, will do.</div>
<div> </div>
<div>Mike B.</div>
<div><br>
<br>
</div>
<div class="gmail_quote">On Tue, Apr 23, 2013 at 11:09 AM, Johnson, Hans J <span dir="ltr">
<<a href="mailto:hans-johnson@uiowa.edu" target="_blank">hans-johnson@uiowa.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left:#ccc 1px solid;margin:0px 0px 0px 0.8ex;padding-left:1ex">
<div style="font-family:Calibri,sans-serif;word-wrap:break-word;font-size:14px">
<div>Michael,</div>
<div><br>
</div>
<div>In order for us to add your contribution to ITK, it must be tested. I added a test that I was 99% sure would fail as a placeholder and reference to what would need to be verified to work on multiple platforms. I don't know how the test should be written,
but I am absolutely confident that a test is needed.</div>
<div><br>
</div>
<div>You patch added an entirely new class, but did not provide a test for the class. This impacts overall code coverage, and more importantly it makes maintenance and stability of ITK difficult.</div>
<div><br>
</div>
<div>Please provide some sort of test for your new features so that we can ensure that it works on different compilers/OS/platforms. At that point we'll be very happy to include your contribution.</div>
<div><br>
</div>
<div>Thank you for looking into this,</div>
<div><br>
</div>
<div>Hans</div>
<div><br>
</div>
<span>
<div style="border-bottom:medium none;text-align:left;border-left:medium none;padding-bottom:0in;padding-left:0in;padding-right:0in;font-family:Calibri;font-size:11pt;border-top:#b5c4df 1pt solid;border-right:medium none;padding-top:3pt">
<span style="font-weight:bold">From: </span>Michael Bowers <<a href="mailto:michaelbowersjhu@gmail.com" target="_blank">michaelbowersjhu@gmail.com</a>><br>
<span style="font-weight:bold">Date: </span>Tuesday, April 23, 2013 9:58 AM<br>
<span style="font-weight:bold">To: </span>Hans Johnson <<a href="mailto:hans-johnson@uiowa.edu" target="_blank">hans-johnson@uiowa.edu</a>><br>
<span style="font-weight:bold">Cc: </span>Arnaud Gelas <<a href="mailto:arnaudgelas@gmail.com" target="_blank">arnaudgelas@gmail.com</a>><br>
<span style="font-weight:bold">Subject: </span>Re: Change in ITK[master]: ENH: Adaptor for vnl Sparse Symmetric Matrix<br>
</div>
<div>
<div>
<div><br>
</div>
<div>
<div>
<div> </div>
<div>Hans,</div>
<div> </div>
<div>So I'm trying to figure the status of this stuff.</div>
<div> </div>
<div>I added a new class with no unit testing code (VNLSparseSymmetricEigensystemTraits). Someone (you or Arnaud) added the class to an existing test (itkParameterizationQuadEdgeMeshFilterTest.cxx) and that's now generating compilation errors. So to go forward
I can either fix the current VNL Traits class or write my own test program. Is that more or less where we are?</div>
<div> </div>
<div>The Eigensystem seems pretty different from the Solvers. Would writing a new test program seem like the wisest course to you at this time?</div>
<div> </div>
<div>Thanks for your help,</div>
<div> </div>
<div>Mike B.</div>
<div> </div>
<div> </div>
<div><br>
</div>
<div class="gmail_quote">On Tue, Apr 16, 2013 at 6:47 AM, Hans J. Johnson (Code Review)
<span dir="ltr"><<a href="mailto:review@kitware.com" target="_blank">review@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left:#ccc 1px solid;margin:0px 0px 0px 0.8ex;padding-left:1ex">
Hans J. Johnson has posted comments on this change.<br>
<div><br>
Change subject: ENH: Adaptor for vnl Sparse Symmetric Matrix<br>
......................................................................<br>
<br>
<br>
</div>
Patch Set 6: Fails<br>
<br>
Updated to match ITK style, and then added a test for the new SSE, I'm 99% sure that the test is going to fail, but at least there is a placeholder for something to fix.<br>
<div>
<div><br>
--<br>
To view, visit <a href="http://review.source.kitware.com/10048" target="_blank">http://review.source.kitware.com/10048</a><br>
To unsubscribe, visit <a href="http://review.source.kitware.com/settings" target="_blank">
http://review.source.kitware.com/settings</a><br>
<br>
Gerrit-MessageType: comment<br>
Gerrit-Change-Id: I7ef2afb82c500de23085dea2063d4fefb10949b9<br>
Gerrit-PatchSet: 6<br>
Gerrit-Project: ITK<br>
Gerrit-Branch: master<br>
Gerrit-Owner: Michael Bowers <<a href="mailto:michaelbowersjhu@gmail.com" target="_blank">michaelbowersjhu@gmail.com</a>><br>
Gerrit-Reviewer: Arnaud Gelas <<a href="mailto:arnaudgelas@gmail.com" target="_blank">arnaudgelas@gmail.com</a>><br>
Gerrit-Reviewer: Hans J. Johnson <<a href="mailto:hans-johnson@uiowa.edu" target="_blank">hans-johnson@uiowa.edu</a>><br>
Gerrit-Reviewer: Michael Bowers <<a href="mailto:michaelbowersjhu@gmail.com" target="_blank">michaelbowersjhu@gmail.com</a>><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</span><br>
<br>
<hr>
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any
retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you.
<hr>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</span>
<div>
<div><br>
<br>
<hr>
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any
retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you.
<hr>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</span><br>
<br>
<hr>
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any
retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you.
<hr>
</div>
<br>_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at<br>
<a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Kitware offers ITK Training Courses, for more information visit:<br>
<a href="http://kitware.com/products/protraining.php" target="_blank">http://kitware.com/products/protraining.php</a><br>
<br>
Please keep messages on-topic and check the ITK FAQ at:<br>
<a href="http://www.itk.org/Wiki/ITK_FAQ" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.itk.org/mailman/listinfo/insight-developers" target="_blank">http://www.itk.org/mailman/listinfo/insight-developers</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br>Unpaid intern in BillsBasement at noware dot com<br>
</div>