<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style id="owaParaStyle">
<!--
p
{margin-bottom:0px;
margin-top:0px}
-->
</style>
</head>
<body>
<div style="direction:ltr; font-family:Tahoma; color:#000000; font-size:10pt">
<p> I have the simple patch up for review, we'll see what people think. I'm CC'ing the developer list.</p>
<p><a href="http://review.source.kitware.com/#/c/11133/">http://review.source.kitware.com/#/c/11133/</a></p>
<p>If it gets moved there, then I wonder about how applications would deal with it. Normally if a library is installed (either system-wide, per user, or as part of a build) you would be able to just have:</p>
<p> </p>
<p>#include "openjpeg.h"</p>
<p> </p>
<p>And not have any additional path. Having an ITK-specific path would mean that the build would no longer work if ITK and your application build were configured against a system OpenJPEG.</p>
<p> </p>
<div style="font-size:16px; font-family:Times New Roman; color:#000000">
<hr tabindex="-1">
<div id="divRpF994939" style="direction:ltr"><font color="#000000" size="2" face="Tahoma"><b>From:</b> Marco Feuerstein [marco.feuerstein@gmail.com]<br>
<b>Sent:</b> Friday, May 03, 2013 2:37 AM<br>
<b>To:</b> Williams, Norman K<br>
<b>Subject:</b> Re: ITK bugs & patches -- openJPEG<br>
</font><br>
</div>
<div></div>
<div>
<div dir="ltr">Kent,
<div><br>
</div>
<div>the rationale for installing it to <span style="font-size:12px; font-family:arial,sans-serif; color:rgb(0,0,0)">${ITK3P_INSTALL_INCLUDE_DIR}/</span><span style="font-size:12px; font-family:arial,sans-serif; color:rgb(0,0,0)">itkopenjpeg for me was that
all other external headers from libs like jpeg, png, tiff, zlib, ... are currently installed to itkjpeg, itkpng, itktiff, itkzlib, ... directories.</span></div>
<div><font color="#000000" face="arial, sans-serif">I just wanted to be conform to this behavior.</font></div>
<div><span style="font-size:12px; font-family:arial,sans-serif; color:rgb(0,0,0)">What do you think? Shall we be different just for openjpeg?</span></div>
<div><span style="font-size:12px; font-family:arial,sans-serif; color:rgb(0,0,0)">Thanks for your help!<br>
</span></div>
<div><span style="font-size:12px; font-family:arial,sans-serif; color:rgb(0,0,0)">Best,<br>
Marco</span></div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Thu, May 2, 2013 at 10:20 PM, Williams, Norman K <span dir="ltr">
<<a href="mailto:norman-k-williams@uiowa.edu" target="_blank">norman-k-williams@uiowa.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="padding-left:1ex; margin:0px 0px 0px 0.8ex; border-left:#ccc 1px solid">
I'm looking at this Jira task you logged for ITK<br>
<br>
<a href="https://itk.icts.uiowa.edu/jira/browse/ITK-3025" target="_blank">https://itk.icts.uiowa.edu/jira/browse/ITK-3025</a><br>
<br>
I've verified that this is indeed a problem. Have you set up an account<br>
for submitting patches on<br>
<a href="http://review.source.kitware.com" target="_blank">http://review.source.kitware.com</a>? Gerrit provides a way to submit patches<br>
and get feedback on them.<br>
<br>
Regarding your patch:<br>
<a href="https://itk.icts.uiowa.edu/jira/secure/attachment/12316/itkopenjpeg.patch" target="_blank">https://itk.icts.uiowa.edu/jira/secure/attachment/12316/itkopenjpeg.patch</a><br>
<br>
It seems to me that it is true that openjpegDllConfig.h should be included<br>
in the installation. What isn't clear to me is why the destination needs<br>
to be ${ITK3P_INSTALL_INCLUDE_DIR}/itkopenjpeg. Was there a rationale for<br>
this?<br>
<br>
BTW the default now for header installation from ITK is to put all ITK<br>
header files into one directory<br>
--<br>
Kent Williams <a href="mailto:norman-k-williams@uiowa.edu" target="_blank">norman-k-williams@uiowa.edu</a><br>
<br>
<br>
<br>
<br>
<br>
<br>
________________________________<br>
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any
retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you.<br>
________________________________<br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
<br>
<br>
<hr>
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any
retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you.
<hr>
</body>
</html>